Seil0/TheCitadelofRicks
1
1
Fork 0
Code Issues 3 Pull Requests Releases 14 Wiki Activity

Update MensaParser for new Mensa website #24

Merged
Seil0 merged 3 commits from fix-mensaparser into master 2022-12-22 15:38:20 +01:00
Conversation 1 Commits 3 Files Changed 8
+593 -672
hannesbraun commented 2022-12-19 20:54:53 +01:00
Collaborator
Copy Link
Copy Source

The MensaParser seems to be broken currently. This should be the required update to get it to work again.

Additionaly, I simplified setting the default values in the StartupController. I think right now, it's easier if only one value needs to be updated instead of three. If there is ever the need to implement a more complex logic, we can still find another solution.

Also, I updated jsoup to 1.15.3 as the previous version had a vulnerability. Not sure if we're affected but an update surely doesn't hurt.

The `MensaParser` seems to be broken currently. This should be the required update to get it to work again. Additionaly, I simplified setting the default values in the `StartupController`. I think right now, it's easier if only one value needs to be updated instead of three. If there is ever the need to implement a more complex logic, we can still find another solution. Also, I updated jsoup to 1.15.3 as the previous version had a vulnerability. Not sure if we're affected but an update surely doesn't hurt.
hannesbraun added 3 commits 2022-12-19 20:54:53 +01:00
Deduplicate default values in StartupController 795ddc516d
Update jsoup from 1.14.3 to 1.15.3 d457627e00 
Version 1.14.3 also included a vulnerability (CVE-2022-36033) that got fixed with 1.15.3.
Update MensaParser for new Mensa website 7174b9b3c8
hannesbraun added the bug label 2022-12-19 20:55:10 +01:00
hannesbraun self-assigned this 2022-12-19 20:55:31 +01:00
hannesbraun requested review from Seil0 2022-12-19 20:55:35 +01:00
hannesbraun force-pushed fix-mensaparser from 7174b9b3c8 to a39da6deba 2022-12-19 21:02:56 +01:00 Compare
Seil0 approved these changes 2022-12-22 15:38:00 +01:00
Seil0 left a comment
Owner
Copy Link
Copy Source

lgtm

lgtm
Seil0 merged commit dc6c41578a into master 2022-12-22 15:38:20 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Seil0
Labels
Clear labels
api
API specific issue
 bug
Something is not working
 code/internal
A code specific issue
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 hs issue
A issue or implementation difficulty that's part of the HS website
 invalid
Something is wrong
 planed
Planed for a further release
question
More information is needed
 under investigation
Is under investigation
wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Assignees
Clear assignees
hannesbraun (Hannes Braun) Seil0 (Jannik)
No Assignees hannesbraun
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seil0/TheCitadelofRicks#24