localhorst/reHDD
1
0
Fork 1
Code Issues 3 Pull Requests Releases 11 Wiki Activity

bugfix/dry-run-tui-freeze (#88)

Browse Source 
Fixes #87

Reviewed-on: #88
Co-authored-by: localhorst <localhorst@mosad.xyz>
Co-committed-by: localhorst <localhorst@mosad.xyz>
This commit is contained in:
Hendrik Schutter
2025-12-12 22:14:47 +01:00
committed by Hendrik Schutter
parent d749f23e77
commit c4a960f3cf
3 changed files with 43 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
README.md
View File

@ -16,9 +16,9 @@ Use [Etcher](https://www.balena.io/etcher/#download) or `dd` to create an bootab
## Screenshot
![Screenshot of reHDD with multiple drives in different states](https://git.mosad.xyz/localhorst/reHDD/raw/commit/c40dfe2cbb8f86490b49caf82db70a10015f06f9/doc/screenshot.png "Screenshot")
## Debian Build Notes
## openSUSE Build Notes
* `apt-get install ncurses-dev git make g++`
* `zypper install ncurses-devel git make gcc-c++`
* `git submodule init`
* `git submodule update`
* `make release`
@ -28,16 +28,8 @@ Use [Etcher](https://www.balena.io/etcher/#download) or `dd` to create an bootab
Just install [reHDDPrinter](https://git.mosad.xyz/localhorst/reHDDPrinter).
No further settings needed.
## Create Standalone with Debian 11
Instructions how to create a standalone machine that boots directly to reHDD. This is aimed for production use, like several drives a day shredding.
* Start reHDD after boot without login (as a tty1 shell)
* Start dmesg after boot without login (as a tty2 shell)
* Start htop after boot without login (as a tty3 shell)
* Upload reHDD log every 12h if wanted
### Software requirements
* `apt-get install hwinfo smartmontools curl htop sudo`
* `zypper install hwinfo smartmontools curl htop sudo`
### Installation
@ -56,7 +48,7 @@ git submodule update
If you want to upload the logs, edit `scripts/reHDDLogUploader.bash` with your nextcloud token
Add your system drive in `/root/reHDD/ignoreDrives.conf` like:
Add ignored drives in `/root/reHDD/ignoreDrives.conf` like:
```e102f49d```
Get the first 8 Bytes from your UUID via `blkid /dev/sdX`

45
src/reHDD.cpp
View File

@ -227,9 +227,9 @@ void reHDD::ThreadShred(Drive *const pDrive)
if (pDrive != nullptr)
{
pDrive->setActionStartTimestamp(); // save timestamp at start of shredding
Shred *pShredTask = new Shred(); // create new shred task
pShredTask->shredDrive(pDrive, &fdShredInformPipe[1]); // start new shred task
delete pShredTask; // delete shred task
Shred *pShredInstance = new Shred(); // create new shred task
pShredInstance->shredDrive(pDrive, &fdShredInformPipe[1]); // start new shred task
delete pShredInstance; // delete shred task
ui->updateTUI(&listDrives, u16SelectedEntry);
}
}
@ -382,7 +382,13 @@ void reHDD::filterIgnoredDrives(list<Drive> *plistDrives)
list<Drive>::iterator it;
for (it = plistDrives->begin(); it != plistDrives->end(); ++it)
{
if (it->getPath().find(systemDrivePath) != std::string::npos) // compare found system drive and current drive
string driveName = it->getPath();
// Remove /dev/ prefix
if (driveName.find("/dev/") == 0)
{
driveName = driveName.substr(5); // Skip "/dev/"
}
if (systemDrivePath.find(driveName) != std::string::npos) // compare found system drive and current drive
{
// system drive found --> ignore this drive
#ifdef LOG_LEVEL_HIGH
@ -709,14 +715,23 @@ bool reHDD::getSystemDrive(string &systemDrive)
continue;
}
// Logger::logThis()->info(currentLine);
// Extract drive name from line (removing tree characters)
if ((cLine[0U] != '|') && (cLine[0U] != '`'))
{
systemDrive = currentLine;
systemDrive.erase(std::remove(systemDrive.begin(), systemDrive.end(), '\n'), systemDrive.end()); // remove newline
systemDrive.erase(std::remove(systemDrive.begin(), systemDrive.end(), ' '), systemDrive.end()); // remove spaces
// Logger::logThis()->info("Drive found: " + systemDrive);
// Find the actual drive name (after tree characters like └─, ├─)
size_t lastAlpha = 0;
for (size_t i = 0; i < systemDrive.length(); i++)
{
if (isalpha(systemDrive[i]))
{
lastAlpha = i;
break;
}
}
systemDrive = systemDrive.substr(lastAlpha);
}
if (currentLine.ends_with(" /boot/efi\n"s))
@ -739,5 +754,17 @@ bool reHDD::getSystemDrive(string &systemDrive)
}
pclose(outputfileHwinfo);
// Remove mountpoint (everything after first space)
size_t spacePos = systemDrive.find(' ');
if (spacePos != std::string::npos)
{
systemDrive = systemDrive.substr(0, spacePos);
}
// Remove all unwanted characters
systemDrive.erase(std::remove(systemDrive.begin(), systemDrive.end(), '\n'), systemDrive.end());
systemDrive.erase(std::remove(systemDrive.begin(), systemDrive.end(), '/'), systemDrive.end());
systemDrive.erase(std::remove(systemDrive.begin(), systemDrive.end(), '\r'), systemDrive.end());
return systemDriveFound;
}

9
src/shred.cpp
View File

@ -40,12 +40,8 @@ int Shred::shredDrive(Drive *drive, int *ipSignalFd)
drive->bWasShredStarted = true; // Mark drive as partly shredded
#ifdef DRYRUN
for (int i = 0; i <= 500; i++)
for (int i = 0; i <= 100; i++)
{
if (drive->state.load() != Drive::TaskState::SHRED_ACTIVE)
{
return 0;
}
drive->setTaskPercentage(i + 0.05);
write(*ipSignalFd, "A", 1);
usleep(20000);
@ -204,9 +200,8 @@ int Shred::shredDrive(Drive *drive, int *ipSignalFd)
Logger::logThis()->info("Shred-Task: Checksum zero: " + to_string(drive->u32DriveChecksumAfterShredding) + " - Drive: " + drive->getSerial());
}
#endif
#endif
cleanup();
#endif
if ((drive->state.load() == Drive::TaskState::SHRED_ACTIVE) || (drive->state.load() == Drive::TaskState::CHECK_SUCCESSFUL) || (drive->state == Drive::TaskState::CHECK_FAILED))
{