Merge pull request 'feature/sata-usb-info' (#76) from feature/sata-usb-info into master

Reviewed-on: #76

README.md

@@ -1,12 +1,20 @@
 # reHDD
 
-## Useful for:
-* checking new drives for the first time
-* checking used drives for their next live
+## Features:
+* show S.M.A.R.T values of attached drives
+* checking used drives for their next live based on threshold limits
+* delete a drive instant with wipefs
 * deleting a drive securely via overwriting
+* only needs a display and keyboard
+* process multiple drives at once
+
+## Download USB Image ##
+See reHDD-Bootable how the live image created: https://git.mosad.xyz/localhorst/reHDD-Bootable
+
+Use [Etcher](https://www.balena.io/etcher/#download) or `dd` to create an bootable USB drive .
 
 ## Screenshot 
-![alt text](https://git.mosad.xyz/localhorst/reHDD/raw/commit/42bc26eac95429e20c0f0d59f684dfec0d600e75/doc/screenshot.png "Screenshot")
+![Screenshot of reHDD with multiple drives in different states](https://git.mosad.xyz/localhorst/reHDD/raw/commit/c40dfe2cbb8f86490b49caf82db70a10015f06f9/doc/screenshot.png "Screenshot")
 
 ## Debian Build Notes
 
@@ -15,6 +23,11 @@
 * `git submodule update`
 * `make release`
 
+## Enable Label Printer ##
+
+Just install [reHDDPrinter](https://git.mosad.xyz/localhorst/reHDDPrinter).
+No further settings needed.
+
 ## Create Standalone with Debian 11
 
 Instructions how to create a standalone machine that boots directly to reHDD. This is aimed for production use, like several drives a day shredding.
@@ -26,7 +39,6 @@ Instructions how to create a standalone machine that boots directly to reHDD. Th
 ### Software requirements
 * `apt-get install hwinfo smartmontools curl htop sudo`
 
-
 ### Installation
 
 clone this repo into /root/

astyle.sh

@@ -1,17 +0,0 @@
-#! /bin/bash
-
-echo starting astyle for $PWD
-
-astyle --style=gnu src/*.cpp
-rm -f src/*.orig
-
-astyle --style=gnu src/logger/*.cpp
-rm -f src/logger/*.orig
-
-astyle --style=gnu include/*.h
-rm -f include/*.orig
-
-astyle --style=gnu include/logger/*.h
-rm -f include//logger/*.orig
-
-echo finished astyle for $PWD

include/delete.h

@@ -13,13 +13,11 @@
 class Delete
 {
 protected:
-
 public:
-    static void deleteDrive(Drive* drive);
+    static void deleteDrive(Drive *drive);
 
 private:
     Delete(void);
-
 };
 
-#endif  // DELETE_H_
+#endif // DELETE_H_

include/drive.h

@@ -14,13 +14,24 @@ class Drive
 {
 
 public:
-    enum TaskState {NONE,
-                    SHRED_SELECTED,
-                    SHRED_ACTIVE,
-                    DELETE_SELECTED,
-                    DELETE_ACTIVE,
-                    FROZEN
-                   } state;
+    enum TaskState
+    {
+        NONE,
+        SHRED_SELECTED,
+        SHRED_ACTIVE, // shred iterations active
+        CHECK_ACTIVE, // optional checking active
+        DELETE_SELECTED,
+        DELETE_ACTIVE,
+        FROZEN
+    } state;
+
+    enum ConnectionType
+    {
+        UNKNOWN,
+        USB,
+        SATA,
+        NVME
+    } connectionType;
 
     struct
     {
@@ -30,35 +41,36 @@ public:
         unsigned long ulSpeedMetricBytesWritten;
     } sShredSpeed;
 
-    bool bWasShredded = false;
-    bool bWasDeleteted = false;
+    bool bWasShredded = false;     // all shred iterations done
+    bool bWasShredStarted = false; // shred was atleast once started
+    bool bWasChecked = false;      // all shred iterations and optional checking done
+    bool bWasDeleted = false;
     bool bIsOffline = false;
-    uint32_t u32DriveChecksumAferShredding = 0U;
+    uint32_t u32DriveChecksumAfterShredding = 0U;
 
 private:
     string sPath;
-    time_t u32Timestamp = 0U; //unix timestamp for detecting a frozen drive
-    double d32TaskPercentage = 0U; //in percent for Shred (1 to 100)
-    time_t u32TimestampTaskStart = 0U; //unix timestamp for duration of an action
-    time_t u32TaskDuration = 0U; //time needed to complete the task
+    time_t u32Timestamp = 0U;          // unix timestamp for detecting a frozen drive
+    double d32TaskPercentage = 0U;     // in percent for Shred (1 to 100)
+    time_t u32TimestampTaskStart = 0U; // unix timestamp for duration of an action
+    time_t u32TaskDuration = 0U;       // time needed to complete the task
 
     struct
     {
         string sModelFamily;
         string sModelName;
         string sSerial;
-        uint64_t u64Capacity = 0U; //in byte
+        uint64_t u64Capacity = 0U; // in byte
         uint32_t u32ErrorCount = 0U;
-        uint32_t u32PowerOnHours = 0U; //in hours
+        uint32_t u32PowerOnHours = 0U; // in hours
         uint32_t u32PowerCycles = 0U;
-        uint32_t u32Temperature = 0U; //in Fahrenheit, just kidding: degree Celsius
+        uint32_t u32Temperature = 0U; // in Fahrenheit, just kidding: degree Celsius
     } sSmartData;
 
 private:
     void setTimestamp();
 
 protected:
-
 public:
     Drive(string path)
     {
@@ -69,21 +81,21 @@ public:
     string getModelFamily(void);
     string getModelName(void);
     string getSerial(void);
-    uint64_t getCapacity(void); //in byte
+    uint64_t getCapacity(void); // in byte
     uint32_t getErrorCount(void);
-    uint32_t getPowerOnHours(void); //in hours
+    uint32_t getPowerOnHours(void); // in hours
     uint32_t getPowerCycles(void);
-    uint32_t getTemperature(void); //in Fahrenheit, just kidding: degree Celsius
+    uint32_t getTemperature(void); // in Fahrenheit, just kidding: degree Celsius
     void checkFrozenDrive(void);
 
-    void setDriveSMARTData( string modelFamily,
-                            string modelName,
-                            string serial,
-                            uint64_t capacity,
-                            uint32_t errorCount,
-                            uint32_t powerOnHours,
-                            uint32_t powerCycles,
-                            uint32_t temperature);
+    void setDriveSMARTData(string modelFamily,
+                           string modelName,
+                           string serial,
+                           uint64_t capacity,
+                           uint32_t errorCount,
+                           uint32_t powerOnHours,
+                           uint32_t powerCycles,
+                           uint32_t temperature);
 
     string sCapacityToText();
     string sErrorCountToText();
@@ -99,7 +111,6 @@ public:
 
     void calculateTaskDuration();
     time_t getTaskDuration();
-
 };
 
-#endif  // DRIVE_H_
+#endif // DRIVE_H_

include/logger/logger.h

@@ -28,26 +28,26 @@
 
 using namespace std;
 
-#define MENU_LINE_SIZE 110 //Size of menu lines
+#define MENU_LINE_SIZE 110 // Size of menu lines
 
 #ifndef LOG_PATH
-//#define LOG_PATH "./test.txt"
+// #define LOG_PATH "./test.txt"
 #endif
 
 #ifndef DESCRIPTION
-#define DESCRIPTION "Software-Name - Copyright Company 2020"        //use your values here
+#define DESCRIPTION "Software-Name - Copyright Company 2020" // use your values here
 #endif
 
 #ifndef DEVICE_ID
-#define DEVICE_ID  "Device-Name"                                    //use your values here
+#define DEVICE_ID "Device-Name" // use your values here
 #endif
 
 #ifndef SOFTWARE_VERSION
-#define SOFTWARE_VERSION  "0.1.1.8"                                 //use your values here
+#define SOFTWARE_VERSION "0.1.1.8" // use your values here
 #endif
 
 #ifndef HARDWARE_VERSION
-#define HARDWARE_VERSION  "7.77.9"                                  //use your values here
+#define HARDWARE_VERSION "7.77.9" // use your values here
 #endif
 
 class Logger
@@ -68,13 +68,12 @@ private:
     ~Logger();
 
 public:
-
     void info(string s);
     void warning(string s);
     void error(string s);
     void newLine();
 
-    static Logger* logThis();
+    static Logger *logThis();
 };
 
-#endif  // LOGGER_H_
+#endif // LOGGER_H_

include/printer.h

@@ -0,0 +1,56 @@
+/**
+ * @file    printer.h
+ * @brief   Send drive data to printer service using ipc msg queue
+ * @author  Hendrik Schutter
+ * @date    24.11.2022
+ */
+
+#ifndef PRINTER_H_
+#define PRINTER_H_
+
+#include "reHDD.h"
+
+#include <sys/ipc.h>
+#include <sys/msg.h>
+
+#define STR_BUFFER_SIZE 64U
+#define IPC_MSG_QUEUE_KEY 0x1B11193C0
+
+typedef struct
+{
+    char caDriveIndex[STR_BUFFER_SIZE];
+    char caDriveHours[STR_BUFFER_SIZE];
+    char caDriveCycles[STR_BUFFER_SIZE];
+    char caDriveErrors[STR_BUFFER_SIZE];
+    char caDriveShredTimestamp[STR_BUFFER_SIZE];
+    char caDriveShredDuration[STR_BUFFER_SIZE];
+    char caDriveCapacity[STR_BUFFER_SIZE];
+    char caDriveState[STR_BUFFER_SIZE];
+    char caDriveModelFamily[STR_BUFFER_SIZE];
+    char caDriveModelName[STR_BUFFER_SIZE];
+    char caDriveSerialnumber[STR_BUFFER_SIZE];
+    char caDriveReHddVersion[STR_BUFFER_SIZE];
+
+} t_driveData;
+
+typedef struct
+{
+    long msg_queue_type;
+    t_driveData driveData;
+} t_msgQueueData;
+
+class Printer
+{
+protected:
+public:
+    static Printer *getPrinter();
+    void print(Drive *drive);
+
+private:
+    static bool instanceFlag;
+    static Printer *single;
+    int msqid;
+    Printer();
+    ~Printer();
+};
+#endif // PRINTER_H_

include/reHDD.h

@@ -8,34 +8,34 @@
 #ifndef REHDD_H_
 #define REHDD_H_
 
-#define REHDD_VERSION "bV0.3.0"
+#define REHDD_VERSION "V1.2.0"
 
 // Drive handling Settings
-#define WORSE_HOURS   19200 //mark drive if at this limit or beyond
-#define WORSE_POWERUP 10000  //mark drive if at this limit or beyond
-#define WORSE_TEMPERATURE 55 //mark drive if at this limit or beyond
+#define WORSE_HOURS 19200    // mark drive if at this limit or beyond
+#define WORSE_POWERUP 10000  // mark drive if at this limit or beyond
+#define WORSE_TEMPERATURE 55 // mark drive if at this limit or beyond
 #define SHRED_ITERATIONS 3U
-#define FROZEN_TIMEOUT 20 //After this timeout (minutes) the drive will be marked as frozen, if no progress
-#define METRIC_THRESHOLD 3L*1000L*1000L*1000L //calc shred speed with this minimum of time delta
+#define FROZEN_TIMEOUT 20                           // After this timeout (minutes) the drive will be marked as frozen, if no progress
+#define METRIC_THRESHOLD 3L * 1000L * 1000L * 1000L // calc shred speed with this minimum of time delta
 
 // Logger Settings
 #define LOG_PATH "./reHDD.log"
-#define DESCRIPTION "reHDD - Copyright Hendrik Schutter 2022"
-#define DEVICE_ID  "generic"
-#define SOFTWARE_VERSION  "alpha"
-#define HARDWARE_VERSION  "generic"
+#define DESCRIPTION "reHDD - Copyright Hendrik Schutter 2025"
+#define DEVICE_ID "generic"
+#define SOFTWARE_VERSION REHDD_VERSION
+#define HARDWARE_VERSION "generic"
 
-//#define LOG_LEVEL_HIGH  //log everything, like drive scan thread
+// #define LOG_LEVEL_HIGH // log everything, like drive scan thread
 #ifndef LOG_LEVEL_HIGH
-#define LOG_LEVEL_LOW   //log only user actions and tasks 
+#define LOG_LEVEL_LOW // log only user actions and tasks
 #endif
 
 // Logic
-//#define DRYRUN //don´t touch the drives
-#define FROZEN_ALERT //show alert if drive is frozen
-#define ZERO_CHECK_ALERT //check drive after shred if all bytes are zero, show alert if this fails
+// #define DRYRUN    // don't touch the drives
+#define FROZEN_ALERT // show alert if drive is frozen
+#define ZERO_CHECK   // check drive after shred if all bytes are zero, show alert if this fails
 
-//IPC pipes
+// IPC pipes
 #define READ 0
 #define WRITE 1
 
@@ -64,11 +64,13 @@ using namespace std;
 #include "shred.h"
 #include "delete.h"
 #include "tui.h"
+#include "printer.h"
 #include "logger/logger.h"
 
-extern Logger* logging;
+extern Logger *logging;
 
-template <typename T, typename I> T* iterator_to_pointer(I i)
+template <typename T, typename I>
+T *iterator_to_pointer(I i)
 {
     return (&(*i));
 }
@@ -76,30 +78,31 @@ template <typename T, typename I> T* iterator_to_pointer(I i)
 class reHDD
 {
 protected:
-
 public:
     reHDD(void);
     static void app_logic();
 
 private:
-
-    static void searchDrives(list <Drive>* plistDrives);
-    static void printDrives(list <Drive>* plistDrives);
-    static void startShredAllDrives(list <Drive>* plistDrives);
-    static void updateShredMetrics(list <Drive>* plistDrives);
-    static void filterIgnoredDrives(list <Drive>* plistDrives);
-    static void filterNewDrives(list <Drive>* plistOldDrives, list <Drive>* plistNewDrives);
-    static void addSMARTData(list <Drive>* plistDrives);
-    static void ThreadScannDevices();
+    static void searchDrives(list<Drive> *plistDrives);
+    static void printDrives(list<Drive> *plistDrives);
+    static void startShredAllDrives(list<Drive> *plistDrives);
+    static void stopShredAllDrives(list<Drive> *plistDrives);
+    static void updateShredMetrics(list<Drive> *plistDrives);
+    static void filterIgnoredDrives(list<Drive> *plistDrives);
+    static void filterInvalidDrives(list<Drive> *plistDrives);
+    static void filterNewDrives(list<Drive> *plistOldDrives, list<Drive> *plistNewDrives);
+    static void addSMARTData(list<Drive> *plistDrives);
+    static void ThreadScanDevices();
     static void ThreadUserInput();
-    static void ThreadShred(Drive* const pDrive);
+    static void ThreadShred(Drive *const pDrive);
     static void ThreadDelete();
     static void ThreadCheckFrozenDrives();
     static void handleArrowKey(TUI::UserInput userInput);
     static void handleEnter();
     static void handleESC();
     static void handleAbort();
-    static Drive* getSelectedDrive();
+    static Drive *getSelectedDrive();
+    static bool getSystemDrive(string &systemDrive);
 };
 
-#endif  // REHDD_H_
+#endif // REHDD_H_

include/shred.h

@@ -17,26 +17,23 @@
 #include <unistd.h>
 #include <string.h>
 
+#define CHUNK_SIZE 1024 * 1024 * 32 // amount of bytes that are overwritten at once --> 32MB
+#define TFNG_DATA_SIZE CHUNK_SIZE   // amount of bytes used by tfng
 
-#define CHUNK_SIZE 1024*1024*32 //amount of bytes that are overwritten at once --> 32MB
-#define TFNG_DATA_SIZE CHUNK_SIZE //amount of bytes used by tfng
-
-//#define DEMO_DRIVE_SIZE 1024*1024*256L // 256MB
-//#define DEMO_DRIVE_SIZE 1024*1024*1024L // 1GB
-//#define DEMO_DRIVE_SIZE 5*1024*1024*1024L // 5GB
-//#define DEMO_DRIVE_SIZE 1024*1024*1024*10L // 10GB
+// #define DEMO_DRIVE_SIZE 1024*1024*256L // 256MB
+// #define DEMO_DRIVE_SIZE 1024*1024*1024L // 1GB
+// #define DEMO_DRIVE_SIZE 5*1024*1024*1024L // 5GB
+// #define DEMO_DRIVE_SIZE 1024*1024*1024*10L // 10GB
 
 typedef int fileDescriptor;
 
 class Shred
 {
 protected:
-
 public:
-
     Shred();
     ~Shred();
-    int shredDrive(Drive* drive, int* ipSignalFd);
+    int shredDrive(Drive *drive, int *ipSignalFd);
 
 private:
     fileDescriptor randomSrcFileDiscr;
@@ -44,16 +41,15 @@ private:
     unsigned char caTfngData[TFNG_DATA_SIZE];
     unsigned char caReadBuffer[CHUNK_SIZE];
     unsigned long ulDriveByteSize;
-    unsigned long ulDriveByteOverallCount = 0; //all bytes shredded in all iterations + checking -> used for progress calculation
+    unsigned long ulDriveByteOverallCount = 0; // all bytes shredded in all iterations + checking -> used for progress calculation
     double d32Percent = 0.0;
     double d32TmpPercent = 0.0;
 
     inline double calcProgress();
     int iRewindDrive(fileDescriptor file);
     unsigned long getDriveSizeInBytes(fileDescriptor file);
-    unsigned int uiCalcChecksum(fileDescriptor file, Drive* drive, int* ipSignalFd);
+    unsigned int uiCalcChecksum(fileDescriptor file, Drive *drive, int *ipSignalFd);
     void cleanup();
-
 };
 
-#endif  // SHRED_H_
+#endif // SHRED_H_

include/smart.h

@@ -13,30 +13,21 @@
 class SMART
 {
 protected:
-
 public:
-    static void readSMARTData(Drive* drive);
+    static void readSMARTData(Drive *drive);
 
 private:
     SMART(void);
 
-    static void parseModelFamily(string sLine);
-    static void parseModelName(string sLine);
-    static void parseSerial(string sLine);
-    static void parseCapacity(string sLine);
-    static void parseErrorCount(string sLine);
-    static void parsePowerOnHours(string sLine);
-    static void parsePowerCycle(string sLine);
-    static void parseTemperature(string sLine);
-
-    static  string modelFamily;
-    static  string modelName;
-    static  string serial;
-    static  uint64_t capacity;
-    static  uint32_t errorCount;
-    static  uint32_t powerOnHours;
-    static  uint32_t powerCycle;
-    static  uint32_t temperature;
+    static bool parseExitStatus(string sLine, uint8_t &status);
+    static bool parseModelFamily(string sLine, string &modelFamily);
+    static bool parseModelName(string sLine, string &modelName);
+    static bool parseSerial(string sLine, string &serial);
+    static bool parseCapacity(string sLine, uint64_t &capacity);
+    static bool parseErrorCount(string sLine, uint32_t &errorCount);
+    static bool parsePowerOnHours(string sLine, uint32_t &powerOnHours);
+    static bool parsePowerCycles(string sLine, uint32_t &powerCycles);
+    static bool parseTemperature(string sLine, uint32_t &temperature);
 };
 
-#endif  // SMART_H_
+#endif // SMART_H_

include/tui.h

@@ -12,17 +12,28 @@
 
 #define COLOR_AREA_STDSCR 1
 #define COLOR_AREA_OVERVIEW 2
-#define COLOR_AREA_ENTRY 3
-#define COLOR_AREA_ENTRY_SELECTED 4
-#define COLOR_AREA_DETAIL 5
+#define COLOR_AREA_ENTRY_EVEN 3
+#define COLOR_AREA_ENTRY_ODD 4
+#define COLOR_AREA_ENTRY_SELECTED 5
+#define COLOR_AREA_DETAIL 6
 
 class TUI
 {
 protected:
-
 public:
-
-    enum UserInput { UpKey, DownKey, Abort, Shred, ShredAll, Delete, Enter, ESC, Undefined};
+    enum UserInput
+    {
+        UpKey,
+        DownKey,
+        Abort,
+        Shred,
+        ShredAll,
+        Delete,
+        Enter,
+        ESC,
+        Terminate,
+        Undefined
+    };
     struct MenuState
     {
         bool bAbort;
@@ -36,7 +47,7 @@ public:
 
     static void initTUI();
 
-    void updateTUI(list <Drive>* plistDrives,  uint8_t u8SelectedEntry);
+    void updateTUI(list<Drive> *plistDrives, uint8_t u8SelectedEntry);
 
     static enum UserInput readUserInput();
 
@@ -45,28 +56,28 @@ private:
     static string sRamUsage;
     static string sLocalTime;
 
-    WINDOW* overview;
-    WINDOW* systemview;
-    WINDOW* detailview;
-    WINDOW* menuview;
-    WINDOW* dialog;
-    WINDOW* smartWarning;
+    WINDOW *overview;
+    WINDOW *systemview;
+    WINDOW *detailview;
+    WINDOW *menuview;
+    WINDOW *dialog;
+    WINDOW *smartWarning;
 
-    static void centerTitle(WINDOW *pwin, const char * title);
-    static WINDOW *createOverViewWindow( int iXSize, int iYSize);
-    static WINDOW *createDetailViewWindow( int iXSize, int iYSize, int iXStart, Drive drive);
-    static WINDOW *overwriteDetailViewWindow( int iXSize, int iYSize, int iXStart);
-    static WINDOW *createEntryWindow(int iXSize, int iYSize, int iXStart, int iYStart, int iListIndex, string sModelFamily, string sSerial, string sCapacity, string sState, string sTime, string sSpeed, string sTemp, bool bSelected);
+    static void centerTitle(WINDOW *pwin, const char *title);
+    static WINDOW *createOverViewWindow(int iXSize, int iYSize);
+    static WINDOW *createDetailViewWindow(int iXSize, int iYSize, int iXStart, Drive drive);
+    static WINDOW *overwriteDetailViewWindow(int iXSize, int iYSize, int iXStart);
+    static WINDOW *createEntryWindow(int iXSize, int iYSize, int iXStart, int iYStart, int iListIndex, string sModelFamily, string sSerial, string sCapacity, string sState, string sTime, string sSpeed, string sTemp, string sConnection, bool bSelected);
     static WINDOW *createSystemStats(int iXSize, int iYSize, int iXStart, int iYStart);
     static WINDOW *createMenuView(int iXSize, int iYSize, int iXStart, int iYStart, struct MenuState menustate);
     static WINDOW *createDialog(int iXSize, int iYSize, int iXStart, int iYStart, string selectedTask, string optionA, string optionB);
-    static WINDOW* createFrozenWarning(int iXSize, int iYSize, int iXStart, int iYStart, string sPath, string sModelFamily, string sModelName, string sSerial, string sProgress);
-    static WINDOW* createSmartWarning(int iXSize, int iYSize, int iXStart, int iYStart, string sPath, uint32_t u32PowerOnHours, uint32_t u32PowerCycles,  uint32_t u32ErrorCount, uint32_t u32Temperature);
-    static WINDOW* createZeroChecksumWarning(int iXSize, int iYSize, int iXStart, int iYStart, string sPath, string sModelFamily, string sModelName, string sSerial, uint32_t u32Checksum);
+    static WINDOW *createFrozenWarning(int iXSize, int iYSize, int iXStart, int iYStart, string sPath, string sModelFamily, string sModelName, string sSerial, string sProgress);
+    static WINDOW *createSmartWarning(int iXSize, int iYSize, int iXStart, int iYStart, string sPath, uint32_t u32PowerOnHours, uint32_t u32PowerCycles, uint32_t u32ErrorCount, uint32_t u32Temperature);
+    static WINDOW *createZeroChecksumWarning(int iXSize, int iYSize, int iXStart, int iYStart, string sPath, string sModelFamily, string sModelName, string sSerial, uint32_t u32Checksum);
 
     void displaySelectedDrive(Drive drive, int stdscrX, int stdscrY);
     string formatTimeDuration(time_t u32Duration);
     string formatSpeed(time_t u32ShredTimeDelta, unsigned long ulWrittenBytes);
-
+    static void vTruncateText(string *psText, uint16_t u16MaxLenght);
 };
-#endif  // TUI_H_
+#endif // TUI_H_

makefile

@@ -10,9 +10,9 @@ SRC_PATH = src
 # Space-separated pkg-config libraries used by this project
 LIBS = lib
 # General compiler flags
-COMPILE_FLAGS = -std=c++17 -Wall -Wextra -g
+COMPILE_FLAGS = -std=c++23 -Wall -Wextra -g
 # Additional release-specific flags
-RCOMPILE_FLAGS = -D NDEBUG -O3
+RCOMPILE_FLAGS = -D NDEBUG -Ofast
 # Additional debug-specific flags
 DCOMPILE_FLAGS = -D DEBUG
 # Add additional include paths

scripts/update.sh

@@ -6,9 +6,9 @@ systemctl stop /lib/systemd/system/getty@tty1.service.d
 
 cd /root/reHDD/
 
-FILE=./ignoreDrives.conf
+FILE=../ignoreDrives.conf
 if test -f "$FILE"; then
-   echo backup exits
+   echo "backup exits already"
 else
     cp /root/reHDD/ignoreDrives.conf /root/ignoreDrives.conf
 fi
@@ -23,6 +23,12 @@ git checkout master
 
 git pull
 
+git submodule init
+
+git submodule update
+
+make clean
+
 make release
 
 cp  /root/ignoreDrives.conf /root/reHDD/ignoreDrives.conf

src/delete.cpp

@@ -12,11 +12,11 @@
  * \param	pointer of Drive instance
  * \return  void
  */
-void Delete::deleteDrive(Drive* drive)
+void Delete::deleteDrive(Drive *drive)
 
 {
-    size_t len = 0; //lenght of found line
-    char* cLine = NULL; //found line
+    size_t len = 0;     // lenght of found line
+    char *cLine = NULL; // found line
 
 #ifndef DRYRUN
     string sCMD = ("wipefs -af ");
@@ -25,18 +25,22 @@ void Delete::deleteDrive(Drive* drive)
 #endif
 
 #ifdef DRYRUN
-    //cout << "dryrun for " << drive->getPath() << endl;
+    // cout << "dryrun for " << drive->getPath() << endl;
     string sCMD = ("echo");
 #endif
 
-    const char* cpComand = sCMD.c_str();
-    //cout << "delete: " << cpComand << endl;
+    const char *cpComand = sCMD.c_str();
+    // cout << "delete: " << cpComand << endl;
 
-    FILE* deleteCmdOutput = popen(cpComand, "r");
+    if (drive->bWasShredStarted == false)
+    {
+        //only start delete if the drive was not shredded before
+        FILE *deleteCmdOutput = popen(cpComand, "r");
 
-    while ((getline(&cLine, &len, deleteCmdOutput)) != -1)
+        while ((getline(&cLine, &len, deleteCmdOutput)) != -1)
         {
-            //wipefs running
+            // wipefs running
         }
-    pclose(deleteCmdOutput);
+        pclose(deleteCmdOutput);
+    }
 }

src/drive.cpp

@@ -54,16 +54,16 @@ uint32_t Drive::getTemperature(void)
 string Drive::sCapacityToText()
 {
     char acBuffer[16];
-    double dSize = (double) getCapacity();
+    double dSize = (double)getCapacity();
     uint16_t u16UnitIndex = 0;
-    const char* units[] = {"B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"};
-    while (dSize >= 1000)   //using the marketing capacity
-        {
-            dSize /= 1000;
-            u16UnitIndex++;
-        }
+    const char *units[] = {"B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"};
+    while (dSize >= 1000) // using the marketing capacity
+    {
+        dSize /= 1000;
+        u16UnitIndex++;
+    }
 
-    sprintf(acBuffer, "%.*f %s", u16UnitIndex-3, dSize, units[u16UnitIndex]);
+    sprintf(acBuffer, "%.*f %s", u16UnitIndex - 3, dSize, units[u16UnitIndex]);
     return acBuffer;
 }
 
@@ -80,8 +80,8 @@ string Drive::sPowerOnHoursToText()
     stringstream streamDays;
     stringstream streamYears;
 
-    dDays = (double) ((double)u32Hours/(double)24U);
-    dYears = (double) ((double)u32Hours/(double)8760U);
+    dDays = (double)((double)u32Hours / (double)24U);
+    dYears = (double)((double)u32Hours / (double)8760U);
 
     streamDays << fixed << setprecision(0) << dDays;
     streamYears << fixed << setprecision(1) << dYears;
@@ -98,23 +98,23 @@ string Drive::sPowerCyclesToText()
 
 string Drive::sTemperatureToText()
 {
-    return to_string(getTemperature())+" C";;
+    return to_string(getTemperature()) + " C";
+    ;
 }
 
 void Drive::setTaskPercentage(double d32TaskPercentage)
 {
-    if(d32TaskPercentage <= 100)
-        {
-            this->d32TaskPercentage = d32TaskPercentage;
-            this->setTimestamp(); //set timestamp for this progress for detecting a frozen drive
-        }
+    if (d32TaskPercentage <= 100)
+    {
+        this->d32TaskPercentage = d32TaskPercentage;
+        this->setTimestamp(); // set timestamp for this progress for detecting a frozen drive
+    }
 }
 double Drive::getTaskPercentage(void)
 {
     return this->d32TaskPercentage;
 }
 
-
 /**
  * \brief   set S.M.A.R.T. values in model
  * \param	string modelFamily
@@ -127,14 +127,14 @@ double Drive::getTaskPercentage(void)
  * \param   uint32_t temperature
  * \return  void
  */
-void Drive::setDriveSMARTData( string modelFamily,
-                               string modelName,
-                               string serial,
-                               uint64_t capacity,
-                               uint32_t errorCount,
-                               uint32_t powerOnHours,
-                               uint32_t powerCycle,
-                               uint32_t temperature)
+void Drive::setDriveSMARTData(string modelFamily,
+                              string modelName,
+                              string serial,
+                              uint64_t capacity,
+                              uint32_t errorCount,
+                              uint32_t powerOnHours,
+                              uint32_t powerCycle,
+                              uint32_t temperature)
 {
     this->sSmartData.sModelFamily = modelFamily;
     this->sSmartData.sModelName = modelName;
@@ -179,11 +179,11 @@ void Drive::checkFrozenDrive(void)
     time_t u32localtime;
     time(&u32localtime);
 
-    if((u32localtime - this->u32Timestamp) >= (FROZEN_TIMEOUT*60) && (this->u32Timestamp > 0) && (this->getTaskPercentage() < 100.0))
-        {
-            Logger::logThis()->warning("Drive Frozen: " + this->getModelName() + " " + this->getSerial());
-            this->bWasDeleteted = false;
-            this->bWasShredded = false;
-            this->state = Drive::FROZEN;
-        }
+    if ((u32localtime - this->u32Timestamp) >= (FROZEN_TIMEOUT * 60) && (this->u32Timestamp > 0) && (this->getTaskPercentage() < 100.0))
+    {
+        Logger::logThis()->warning("Drive Frozen: " + this->getModelName() + " " + this->getSerial());
+        this->bWasDeleted = false;
+        this->bWasShredded = false;
+        this->state = Drive::FROZEN;
+    }
 }

src/logger/logger.cpp

@@ -5,21 +5,18 @@
  * @date    04.09.2020
  */
 
-
 #include "../../include/reHDD.h" //for logger settings
 #include "../../include/logger/logger.h"
 
 using namespace std;
 
-string version =  "0.2.1"; //logger version
+string version = "0.2.1"; // logger version
 
 bool Logger::instanceFlag = false;
-Logger* Logger::single = NULL;
+Logger *Logger::single = NULL;
 
 /**
  * \brief   create new logger instance
- * \param	path to log file
- * \param	struct with data
  * \return  instance of Logger
  */
 Logger::Logger()
@@ -97,13 +94,13 @@ void Logger::error(string s)
 void Logger::writeLog(string s)
 {
     ofstream logFile;
-    Logger::mtxLog.lock(); //lock this section for other threads
+    Logger::mtxLog.lock(); // lock this section for other threads
     logFile.open(this->logPath, ios_base::app);
 
-    logFile << (s + "\n"); //append to existing file
+    logFile << (s + "\n"); // append to existing file
 
     logFile.close();
-    Logger::mtxLog.unlock(); //unlock this section for other threads
+    Logger::mtxLog.unlock(); // unlock this section for other threads
 }
 
 /**
@@ -122,21 +119,21 @@ void Logger::newLine()
  */
 string Logger::getTimestamp()
 {
-    struct tm * timeinfo;
+    struct tm *timeinfo;
     struct timeval tv;
     int millisec;
-    char cpDate [80];
-    char buffer [120];
+    char cpDate[80];
+    char buffer[120];
 
     gettimeofday(&tv, NULL);
-    millisec = lrint(tv.tv_usec/1000.0); // Round to nearest millisec
-    if (millisec>=1000)   // Allow for rounding up to nearest second
-        {
-            millisec -=1000;
-            tv.tv_sec++;
-        }
+    millisec = lrint(tv.tv_usec / 1000.0); // Round to nearest millisec
+    if (millisec >= 1000)                  // Allow for rounding up to nearest second
+    {
+        millisec -= 1000;
+        tv.tv_sec++;
+    }
     timeinfo = localtime(&tv.tv_sec);
-    strftime (cpDate,80,"%d/%m/%Y %T",timeinfo);
+    strftime(cpDate, 80, "%d/%m/%Y %T", timeinfo);
     sprintf(buffer, "%s.%03d", cpDate, millisec);
     return buffer;
 }
@@ -149,18 +146,17 @@ string Logger::getTimestamp()
 string Logger::getMacAddress()
 {
     struct ifreq ifr;
-    int s = socket(AF_INET, SOCK_STREAM,0);
+    int s = socket(AF_INET, SOCK_STREAM, 0);
 
     strcpy(ifr.ifr_name, "eth0");
     if (ioctl(s, SIOCGIFHWADDR, &ifr) < 0)
-        {
-            strcpy(ifr.ifr_name, "eno1");
-
-        }
+    {
+        strcpy(ifr.ifr_name, "eno1");
+    }
 
     unsigned char *hwaddr = (unsigned char *)ifr.ifr_hwaddr.sa_data;
-    char buffer [80];
-    sprintf(buffer,"%02X:%02X:%02X:%02X:%02X:%02X", hwaddr[0], hwaddr[1], hwaddr[2],
+    char buffer[80];
+    sprintf(buffer, "%02X:%02X:%02X:%02X:%02X:%02X", hwaddr[0], hwaddr[1], hwaddr[2],
             hwaddr[3], hwaddr[4], hwaddr[5]);
     close(s);
     string tmp = buffer;
@@ -176,22 +172,22 @@ string Logger::getMacAddress()
  */
 string Logger::padStringMenu(char cBorder, string text, uint8_t u8LineLenght)
 {
-    string result(1,cBorder);
+    string result(1, cBorder);
     uint8_t u8TextSize = text.length();
-    uint8_t u8Padding = ((u8LineLenght-u8TextSize)/2);
+    uint8_t u8Padding = ((u8LineLenght - u8TextSize) / 2);
 
-    for(uint8_t i = 0 ; i < u8Padding; i++)
-        {
-            result.append(" ");
-        }
+    for (uint8_t i = 0; i < u8Padding; i++)
+    {
+        result.append(" ");
+    }
 
     result.append(text);
 
-    while((uint8_t)result.length() < (u8LineLenght-1))
-        {
+    while ((uint8_t)result.length() < (u8LineLenght - 1))
+    {
 
-            result.append(" ");
-        }
+        result.append(" ");
+    }
 
     result.append(string(1, cBorder));
     return result;
@@ -205,12 +201,12 @@ string Logger::padStringMenu(char cBorder, string text, uint8_t u8LineLenght)
  */
 string Logger::menuLine(char cBorder, uint8_t u8LineLenght)
 {
-    string result(1,cBorder);
+    string result(1, cBorder);
 
-    while((uint8_t)result.length() < u8LineLenght)
-        {
-            result.append(string(1, cBorder));
-        }
+    while ((uint8_t)result.length() < u8LineLenght)
+    {
+        result.append(string(1, cBorder));
+    }
     return result;
 }
 
@@ -218,18 +214,16 @@ string Logger::menuLine(char cBorder, uint8_t u8LineLenght)
  * \brief   return a instance of the logger
  * \return  logger obj
  */
-Logger* Logger::logThis()
+Logger *Logger::logThis()
 {
     if (!instanceFlag)
-        {
-            single = new Logger(); //create new obj
-            instanceFlag = true;
-            return single;
-        }
+    {
+        single = new Logger(); // create new obj
+        instanceFlag = true;
+        return single;
+    }
     else
-        {
-            return single; //return existing obj
-        }
+    {
+        return single; // return existing obj
+    }
 }
-
-

src/main.cpp

@@ -16,7 +16,7 @@ int main(void)
 {
     // cout << "refurbishingHddTool" << endl;
 
-    reHDD* app = new reHDD();
+    reHDD *app = new reHDD();
     app->app_logic();
     return EXIT_SUCCESS;
 }

src/printer.cpp

@@ -0,0 +1,84 @@
+/**
+ * @file    printer.cpp
+ * @brief   Send drive data to printer service using ipc msg queue
+ * @author  Hendrik Schutter
+ * @date    24.11.2022
+ */
+
+#include "../include/reHDD.h"
+
+bool Printer::instanceFlag = false;
+Printer *Printer::single = NULL;
+
+/**
+ * \brief   create new Printer instance
+ * \param	path to log file
+ * \param	struct with data
+ * \return  instance of Printer
+ */
+Printer::Printer()
+{
+    if (-1 == (this->msqid = msgget((key_t)IPC_MSG_QUEUE_KEY, IPC_CREAT | 0666)))
+    {
+        Logger::logThis()->error("Printer: Create mgs queue failed!");
+    }
+}
+
+/**
+ * \brief   deconstructor
+ * \return  void
+ */
+Printer::~Printer()
+{
+    instanceFlag = false;
+}
+
+/**
+ * \brief   send data to msg queue
+ * \return  void
+ */
+void Printer::print(Drive *drive)
+{
+    t_msgQueueData msgQueueData;
+    msgQueueData.msg_queue_type = 1;
+
+    sprintf(msgQueueData.driveData.caDriveIndex, "%i", 42); // TODO: get from tui
+    sprintf(msgQueueData.driveData.caDriveState, "shredded");
+    strcpy(msgQueueData.driveData.caDriveModelFamily, drive->getModelFamily().c_str());
+    strcpy(msgQueueData.driveData.caDriveModelName, drive->getModelName().c_str());
+    sprintf(msgQueueData.driveData.caDriveCapacity, "%li", drive->getCapacity());
+    strcpy(msgQueueData.driveData.caDriveSerialnumber, drive->getSerial().c_str());
+    sprintf(msgQueueData.driveData.caDriveHours, "%i", drive->getPowerOnHours());
+    sprintf(msgQueueData.driveData.caDriveCycles, "%i", drive->getPowerCycles());
+    sprintf(msgQueueData.driveData.caDriveErrors, "%i", drive->getErrorCount());
+    sprintf(msgQueueData.driveData.caDriveShredTimestamp, "%li", drive->getActionStartTimestamp());
+    sprintf(msgQueueData.driveData.caDriveShredDuration, "%li", drive->getTaskDuration());
+    sprintf(msgQueueData.driveData.caDriveReHddVersion, REHDD_VERSION);
+
+    if (-1 == msgsnd(this->msqid, &msgQueueData, sizeof(t_msgQueueData) - sizeof(long), 0))
+    {
+        Logger::logThis()->error("Printer: Send mgs queue failed!");
+    }
+    else
+    {
+        Logger::logThis()->info("Printer: print triggered - Drive: " + drive->getSerial());
+    }
+}
+
+/**
+ * \brief   return a instance of the printer
+ * \return  printer obj
+ */
+Printer *Printer::getPrinter()
+{
+    if (!instanceFlag)
+    {
+        single = new Printer(); // create new obj
+        instanceFlag = true;
+        return single;
+    }
+    else
+    {
+        return single; // return existing obj
+    }
+}

src/shred.cpp

@@ -8,14 +8,15 @@
 #include "../include/reHDD.h"
 
 #ifdef __cplusplus
-extern "C" {
+extern "C"
+{
 #endif
 #include "../tfnoisegen/tfprng.h"
 #ifdef __cplusplus
 }
 #endif
 
-const static char *randomsrc = (char*) "/dev/urandom";
+const static char *randomsrc = (char *)"/dev/urandom";
 
 Shred::Shred()
 {
@@ -30,177 +31,183 @@ Shred::~Shred()
  * \param	pointer of Drive instance
  * \return  void
  */
-int Shred::shredDrive(Drive* drive, int* ipSignalFd)
+int Shred::shredDrive(Drive *drive, int *ipSignalFd)
 {
     ostringstream address;
     address << (void const *)&(*drive);
     Logger::logThis()->info("Shred-Task started - Drive: " + drive->getModelName() + "-" + drive->getSerial() + " @" + address.str());
+    drive->bWasShredStarted = true; //Mark drive as partly shredded
 
 #ifdef DRYRUN
-    for(int i = 0; i<=500; i++)
+    for (int i = 0; i <= 500; i++)
+    {
+        if (drive->state != Drive::SHRED_ACTIVE)
         {
-            if(drive->state != Drive::SHRED_ACTIVE)
-                {
-                    return 0;
-                }
-            drive->setTaskPercentage(i+0.05);
-            write(*ipSignalFd, "A",1);
-            usleep(20000);
+            return 0;
         }
+        drive->setTaskPercentage(i + 0.05);
+        write(*ipSignalFd, "A", 1);
+        usleep(20000);
+    }
+    drive->bWasShredded = true;
 #endif
 
 #ifndef DRYRUN
     const char *cpDrivePath = drive->getPath().c_str();
     unsigned char ucKey[TFNG_KEY_SIZE];
 
-    //open random source
+    // open random source
     randomSrcFileDiscr = open(randomsrc, O_RDONLY | O_LARGEFILE);
     if (randomSrcFileDiscr == -1)
-        {
-            std::string errorMsg(strerror(randomSrcFileDiscr));
-            Logger::logThis()->error("Shred-Task: Open random source failed! " + errorMsg + " - Drive: " + drive->getSerial());
-            perror(randomsrc);
-            cleanup();
-            return -1;
-        }
+    {
+        std::string errorMsg(strerror(randomSrcFileDiscr));
+        Logger::logThis()->error("Shred-Task: Open random source failed! " + errorMsg + " - Drive: " + drive->getSerial());
+        perror(randomsrc);
+        cleanup();
+        return -1;
+    }
 
-    //open disk
+    // open disk
     driveFileDiscr = open(cpDrivePath, O_RDWR | O_LARGEFILE);
     if (driveFileDiscr == -1)
-        {
-            std::string errorMsg(strerror(driveFileDiscr));
-            Logger::logThis()->error("Shred-Task: Open drive failed! " + errorMsg + " - Drive: " + drive->getSerial());
-            perror(cpDrivePath);
-            cleanup();
-            return -1;
-        }
+    {
+        std::string errorMsg(strerror(driveFileDiscr));
+        Logger::logThis()->error("Shred-Task: Open drive failed! " + errorMsg + " - Drive: " + drive->getSerial());
+        perror(cpDrivePath);
+        cleanup();
+        return -1;
+    }
 
-    //read key for random generator
-    ssize_t readRet = read(randomSrcFileDiscr, ucKey, sizeof(ucKey)) ;
+    // read key for random generator
+    ssize_t readRet = read(randomSrcFileDiscr, ucKey, sizeof(ucKey));
     if (readRet <= 0)
-        {
-            std::string errorMsg(strerror(readRet));
-            Logger::logThis()->error("Shred-Task: Read random key failed! " + errorMsg + " - Drive: " + drive->getSerial());
-            perror(randomsrc);
-            cleanup();
-            return -1;
-        }
+    {
+        std::string errorMsg(strerror(readRet));
+        Logger::logThis()->error("Shred-Task: Read random key failed! " + errorMsg + " - Drive: " + drive->getSerial());
+        perror(randomsrc);
+        cleanup();
+        return -1;
+    }
 
     tfng_prng_seedkey(ucKey);
 
     this->ulDriveByteSize = getDriveSizeInBytes(driveFileDiscr);
-    drive->sShredSpeed.chronoShredTimestamp = std::chrono::system_clock::now();; //set inital timestamp for speed metric
-    drive->sShredSpeed.ulSpeedMetricBytesWritten = 0U; //uses to calculate speed metric
+    drive->sShredSpeed.chronoShredTimestamp = std::chrono::system_clock::now(); // set inital timestamp for speed metric
+    drive->sShredSpeed.ulSpeedMetricBytesWritten = 0U; // uses to calculate speed metric
 
 #ifdef LOG_LEVEL_HIGH
     Logger::logThis()->info("Shred-Task: Bytes-Size of Drive: " + to_string(this->ulDriveByteSize) + " - Drive: " + drive->getSerial());
 #endif
 
     for (unsigned int uiShredIterationCounter = 0U; uiShredIterationCounter < SHRED_ITERATIONS; uiShredIterationCounter++)
+    {
+        unsigned long ulDriveByteCounter = 0U; // used for one shred-iteration to keep track of the current drive position
+
+        if (uiShredIterationCounter == (SHRED_ITERATIONS - 1))
         {
-            unsigned long ulDriveByteCounter = 0U; //used for one shred-iteration to keep track of the current drive position
+            // last shred iteration --> overwrite (just the write chunk) bytes with zeros instead with random data
+            memset(caTfngData, 0U, CHUNK_SIZE);
+        }
 
-            if(uiShredIterationCounter == (SHRED_ITERATIONS-1))
-                {
-                    //last shred iteration --> overwrite (just the write chunk) bytes with zeros instead with random data
-                    memset(caTfngData, 0U, CHUNK_SIZE);
-                }
+        while (ulDriveByteCounter < ulDriveByteSize)
+        {
+            int iBytesToShred = 0; // Bytes that will be overwritten in this chunk-iteration
 
-            while (ulDriveByteCounter < ulDriveByteSize)
-                {
-                    int iBytesToShred = 0; //Bytes that will be overwritten in this chunk-iteration
+            if (uiShredIterationCounter != (SHRED_ITERATIONS - 1))
+            {
+                // NOT last shred iteration --> generate new random data
+                tfng_prng_genrandom(caTfngData, TFNG_DATA_SIZE);
+            }
 
-                    if(uiShredIterationCounter != (SHRED_ITERATIONS-1))
-                        {
-                            //NOT last shred iteration --> generate new random data
-                            tfng_prng_genrandom(caTfngData, TFNG_DATA_SIZE);
-                        }
+            if ((ulDriveByteSize - ulDriveByteCounter) < CHUNK_SIZE)
+            {
+                iBytesToShred = (ulDriveByteSize - ulDriveByteCounter);
+            }
+            else
+            {
+                iBytesToShred = CHUNK_SIZE;
+            }
 
-                    if((ulDriveByteSize-ulDriveByteCounter) < CHUNK_SIZE)
-                        {
-                            iBytesToShred = (ulDriveByteSize-ulDriveByteCounter);
-                        }
-                    else
-                        {
-                            iBytesToShred = CHUNK_SIZE;
-                        }
+            int iByteShredded = write(driveFileDiscr, caTfngData, iBytesToShred);
 
-                    int iByteShredded = write(driveFileDiscr, caTfngData, iBytesToShred);
+            if (iByteShredded <= 0)
+            {
+                std::string errorMsg(strerror(iByteShredded));
+                Logger::logThis()->error("Shred-Task: Write to drive failed! " + errorMsg + " - Drive: " + drive->getSerial());
+                perror("unable to write random data");
+                cleanup();
+                return -1;
+            }
 
-                    if(iByteShredded <= 0)
-                        {
-                            std::string errorMsg(strerror(iByteShredded));
-                            Logger::logThis()->error("Shred-Task: Write to drive failed! " + errorMsg + " - Drive: " + drive->getSerial());
-                            perror("unable to write random data");
-                            cleanup();
-                            return -1;
-                        }
-
-                    ulDriveByteCounter += iByteShredded;
-                    ulDriveByteOverallCount += iByteShredded;
-                    d32Percent = this->calcProgress();
-                    drive->sShredSpeed.ulSpeedMetricBytesWritten += iByteShredded;
+            ulDriveByteCounter += iByteShredded;
+            ulDriveByteOverallCount += iByteShredded;
+            d32Percent = this->calcProgress();
+            drive->sShredSpeed.ulSpeedMetricBytesWritten += iByteShredded;
 
 #ifdef LOG_LEVEL_HIGH
-                    Logger::logThis()->info("Shred-Task: ByteCount: " + to_string(ulDriveByteCounter) +  " - iteration: " + to_string((uiShredIterationCounter+1)) + " - progress: " + to_string(d32Percent) + " - Drive: " + drive->getSerial());
+            Logger::logThis()->info("Shred-Task: ByteCount: " + to_string(ulDriveByteCounter) + " - iteration: " + to_string((uiShredIterationCounter + 1)) + " - progress: " + to_string(d32Percent) + " - Drive: " + drive->getSerial());
 #endif
-                    if((d32Percent-d32TmpPercent) >= 0.01)
-                        {
-                            //set shred percantage
-                            drive->setTaskPercentage(d32TmpPercent);
-                            d32TmpPercent = d32Percent;
-                            //signal process in shreding
-                            write(*ipSignalFd, "A",1);
-                        }
+            if ((d32Percent - d32TmpPercent) >= 0.01)
+            {
+                // set shred percantage
+                drive->setTaskPercentage(d32TmpPercent);
+                d32TmpPercent = d32Percent;
+                // signal process in shreding
+                write(*ipSignalFd, "A", 1);
+            }
 
-                    if(drive->state != Drive::SHRED_ACTIVE)
-                        {
-                            drive->setTaskPercentage(0);
-                            d32Percent = 0.00;
-                            d32TmpPercent = 0.00;
-                            ulDriveByteCounter = 0U;
-                            Logger::logThis()->info("Aborted shred  for: " + drive->getModelName() + "-" +  drive->getSerial());
-                            cleanup();
-                            return -1;
-                        }
-                    //end one chunk write
-                }
-            if(0 != iRewindDrive(driveFileDiscr))
-                {
-                    Logger::logThis()->error("Shred-Task: Unable to rewind drive! - Drive: " + drive->getSerial());
-                    cleanup();
-                    return -1;
-                }
-            //end one shred iteration
+            if (drive->state != Drive::SHRED_ACTIVE)
+            {
+                drive->setTaskPercentage(0);
+                d32Percent = 0.00;
+                d32TmpPercent = 0.00;
+                ulDriveByteCounter = 0U;
+                Logger::logThis()->info("Aborted shred  for: " + drive->getModelName() + "-" + drive->getSerial());
+                cleanup();
+                return -1;
+            }
+            // end one chunk write
         }
-    //end of all shred iteratio
+        if (0 != iRewindDrive(driveFileDiscr))
+        {
+            Logger::logThis()->error("Shred-Task: Unable to rewind drive! - Drive: " + drive->getSerial());
+            cleanup();
+            return -1;
+        }
+        // end one shred iteration
+    }
+    // end of all shred iteratio
 
-    tfng_prng_seedkey(NULL); //reset random generator
+    tfng_prng_seedkey(NULL); // reset random generator
 
-#ifdef ZERO_CHECK_ALERT
-    drive->u32DriveChecksumAferShredding = uiCalcChecksum(driveFileDiscr, drive, ipSignalFd);
+    drive->bWasShredded = true;
+    Logger::logThis()->info("Shred-Task finished - Drive: " + drive->getModelName() + "-" + drive->getSerial() + " @" + address.str());
+#ifdef ZERO_CHECK
+    drive->state = Drive::CHECK_ACTIVE;
+    Logger::logThis()->info("Check-Task started - Drive: " + drive->getModelName() + "-" + drive->getSerial() + " @" + address.str());
+    drive->u32DriveChecksumAfterShredding = uiCalcChecksum(driveFileDiscr, drive, ipSignalFd);
 #ifdef LOG_LEVEL_HIGH
-    if (drive->u32DriveChecksumAferShredding != 0)
-        {
-            Logger::logThis()->info("Shred-Task: Checksum not zero: " + to_string(drive->u32DriveChecksumAferShredding) + " - Drive: " + drive->getSerial());
-        }
+    if (drive->u32DriveChecksumAfterShredding != 0)
+    {
+        Logger::logThis()->info("Shred-Task: Checksum not zero: " + to_string(drive->u32DriveChecksumAfterShredding) + " - Drive: " + drive->getSerial());
+    }
     else
-        {
-            Logger::logThis()->info("Shred-Task: Checksum zero: " + to_string(drive->u32DriveChecksumAferShredding) + " - Drive: " + drive->getSerial());
-        }
+    {
+        Logger::logThis()->info("Shred-Task: Checksum zero: " + to_string(drive->u32DriveChecksumAfterShredding) + " - Drive: " + drive->getSerial());
+    }
 #endif
 #endif
 #endif
 
     cleanup();
 
-    if(drive->state == Drive::SHRED_ACTIVE)
-        {
-            drive->bWasShredded = true;
-            drive->state= Drive::NONE;
-            drive->setTaskPercentage(0.0);
-            Logger::logThis()->info("Finished shred for: " + drive->getModelName() + "-" +  drive->getSerial());
-        }
+    if ((drive->state == Drive::SHRED_ACTIVE) || (drive->state == Drive::CHECK_ACTIVE))
+    {
+        drive->state = Drive::NONE;
+        drive->setTaskPercentage(0.0);
+        Printer::getPrinter()->print(drive);
+        Logger::logThis()->info("Finished shred/check for: " + drive->getModelName() + "-" + drive->getSerial());
+    }
     return 0;
 }
 /**
@@ -213,33 +220,33 @@ double Shred::calcProgress()
 {
     unsigned int uiMaxShredIteration = SHRED_ITERATIONS;
 
-#ifdef ZERO_CHECK_ALERT
-    uiMaxShredIteration++; //increment because we will check after SHRED_ITERATIONS the drive for non-zero bytes
+#ifdef ZERO_CHECK
+    uiMaxShredIteration++; // increment because we will check after SHRED_ITERATIONS the drive for non-zero bytes
 #endif
-    return (double) (((double) ulDriveByteOverallCount) / ((double)this->ulDriveByteSize*uiMaxShredIteration))*100.0f;
+    return (double)(((double)ulDriveByteOverallCount) / ((double)this->ulDriveByteSize * uiMaxShredIteration)) * 100.0f;
 }
 
 int Shred::iRewindDrive(fileDescriptor file)
 {
-    if(0 != lseek(file, 0L, SEEK_SET))
-        {
-            perror("unable to rewind drive");
-            return -1;
-        }
+    if (0 != lseek(file, 0L, SEEK_SET))
+    {
+        perror("unable to rewind drive");
+        return -1;
+    }
     else
-        {
-            return 0;
-        }
+    {
+        return 0;
+    }
 }
 
 unsigned long Shred::getDriveSizeInBytes(fileDescriptor file)
 {
     unsigned long ulDriveSizeTmp = lseek(file, 0L, SEEK_END);
 
-    if(0 != iRewindDrive(file))
-        {
-            ulDriveSizeTmp = 0U;
-        }
+    if (0 != iRewindDrive(file))
+    {
+        ulDriveSizeTmp = 0U;
+    }
 
 #ifdef DEMO_DRIVE_SIZE
     ulDriveSizeTmp = DEMO_DRIVE_SIZE;
@@ -247,40 +254,46 @@ unsigned long Shred::getDriveSizeInBytes(fileDescriptor file)
     return ulDriveSizeTmp;
 }
 
-unsigned int Shred::uiCalcChecksum(fileDescriptor file,Drive* drive, int* ipSignalFd)
+unsigned int Shred::uiCalcChecksum(fileDescriptor file, Drive *drive, int *ipSignalFd)
 {
     unsigned int uiChecksum = 0;
     unsigned long ulDriveByteCounter = 0U;
     while (ulDriveByteCounter < ulDriveByteSize)
+    {
+        int iBytesToCheck = 0;
+        if ((ulDriveByteSize - ulDriveByteCounter) < CHUNK_SIZE)
         {
-            int iBytesToCheck = 0;
-            if((ulDriveByteSize-ulDriveByteCounter) < CHUNK_SIZE)
-                {
-                    iBytesToCheck = (ulDriveByteSize-ulDriveByteCounter);
-                }
-            else
-                {
-                    iBytesToCheck = CHUNK_SIZE;
-                }
-            int iReadBytes = read(file, caReadBuffer, iBytesToCheck);
-            for (int iReadBytesCounter = 0U; iReadBytesCounter < iReadBytes; iReadBytesCounter++)
-                {
-                    uiChecksum += caReadBuffer[iReadBytesCounter];
-                }
-            ulDriveByteCounter += iReadBytes;
-            ulDriveByteOverallCount += iReadBytes;
-            d32Percent = this->calcProgress();
-            drive->sShredSpeed.ulSpeedMetricBytesWritten += iReadBytes;
-#ifdef LOG_LEVEL_HIGH
-            Logger::logThis()->info("Shred-Task (Checksum): ByteCount: " + to_string(ulDriveByteCounter) + " - progress: " + to_string(d32Percent) + " - Drive: " + drive->getSerial());
-#endif
-            if((d32Percent-d32TmpPercent) >= 0.01)
-                {
-                    drive->setTaskPercentage(d32TmpPercent);
-                    d32TmpPercent = d32Percent;
-                    write(*ipSignalFd, "A",1);
-                }
+            iBytesToCheck = (ulDriveByteSize - ulDriveByteCounter);
         }
+        else
+        {
+            iBytesToCheck = CHUNK_SIZE;
+        }
+        int iReadBytes = read(file, caReadBuffer, iBytesToCheck);
+        for (int iReadBytesCounter = 0U; iReadBytesCounter < iReadBytes; iReadBytesCounter++)
+        {
+            uiChecksum += caReadBuffer[iReadBytesCounter];
+        }
+        ulDriveByteCounter += iReadBytes;
+        ulDriveByteOverallCount += iReadBytes;
+        d32Percent = this->calcProgress();
+        drive->sShredSpeed.ulSpeedMetricBytesWritten += iReadBytes;
+
+#ifdef LOG_LEVEL_HIGH
+        Logger::logThis()->info("Shred-Task (Checksum): ByteCount: " + to_string(ulDriveByteCounter) + " - progress: " + to_string(d32Percent) + " - Drive: " + drive->getSerial());
+#endif
+
+        if (((d32Percent - d32TmpPercent) >= 0.01) || (d32Percent == 100.0))
+        {
+            drive->setTaskPercentage(d32TmpPercent);
+            d32TmpPercent = d32Percent;
+#ifdef LOG_LEVEL_HIGH
+            Logger::logThis()->info("send progress signal to main loop (check)");
+#endif
+            write(*ipSignalFd, "A", 1);
+        }
+    }
+    drive->bWasChecked = true;
     return uiChecksum;
 }
 

src/smart.cpp

@@ -7,198 +7,279 @@
 
 #include "../include/reHDD.h"
 
-string SMART::modelFamily;
-string SMART::modelName;
-string SMART::serial;
-uint64_t SMART::capacity = 0U;
-uint32_t SMART::errorCount = 0U;
-uint32_t SMART::powerOnHours = 0U;
-uint32_t SMART::powerCycle = 0U;
-uint32_t SMART::temperature = 0U;
-
 /**
  * \brief   get and set S.M.A.R.T. values in Drive
  * \param	pointer of Drive instance
  * \return  void
  */
-void SMART::readSMARTData(Drive* drive)
+void SMART::readSMARTData(Drive *drive)
 {
+    string modelFamily;
+    string modelName;
+    string serial;
+    uint64_t capacity = 0U;
+    uint32_t errorCount = 0U;
+    uint32_t powerOnHours = 0U;
+    uint32_t powerCycles = 0U;
+    uint32_t temperature = 0U;
+
     modelFamily.clear();
     modelName.clear();
     serial.clear();
-    capacity = 0U;
-    errorCount = 0U;
-    powerOnHours = 0U;
-    powerCycle = 0U;
-    temperature = 0U;
 
-    size_t len = 0; //lenght of found line
-    char* cLine = NULL; //found line
+    string sSmartctlCommands[] = {" --json -a ", " --json -d sntjmicron -a ", " --json -d sntasmedia -a ", " --json -d sntrealtek -a ", " --json -d sat -a "};
 
-    string sCMD = ("smartctl --json -a ");
-    sCMD.append(drive->getPath());
-    const char* cpComand = sCMD.c_str();
+    for (string sSmartctlCommand : sSmartctlCommands)
+    {
+        string sCMD = ("smartctl");
+        sCMD.append(sSmartctlCommand);
+        sCMD.append(drive->getPath());
+        const char *cpComand = sCMD.c_str();
 
-    FILE* outputfileSmart = popen(cpComand, "r");
+        //Logger::logThis()->info(cpComand);
 
-    while ((getline(&cLine, &len, outputfileSmart)) != -1)
+        FILE *outputfileSmart = popen(cpComand, "r");
+        size_t len = 0U;     // length of found line
+        char *cLine = NULL; // found line
+        uint8_t status = 255U;
+
+        while ((getline(&cLine, &len, outputfileSmart)) != -1)
         {
             string sLine = string(cLine);
 
-            SMART::parseModelFamily(sLine);
-            SMART::parseModelName(sLine);
-            SMART::parseSerial(sLine);
-            SMART::parseCapacity(sLine);
-            SMART::parseErrorCount(sLine);
-            SMART::parsePowerOnHours(sLine);
-            SMART::parsePowerCycle(sLine);
-            SMART::parseTemperature(sLine);
+            SMART::parseExitStatus(sLine, status);
+            SMART::parseModelFamily(sLine, modelFamily);
+            SMART::parseModelName(sLine, modelName);
+            SMART::parseSerial(sLine, serial);
+            SMART::parseCapacity(sLine, capacity);
+            SMART::parseErrorCount(sLine, errorCount);
+            SMART::parsePowerOnHours(sLine, powerOnHours);
+            SMART::parsePowerCycles(sLine, powerCycles);
+            SMART::parseTemperature(sLine, temperature);
         }
-    pclose(outputfileSmart);
-    drive->setDriveSMARTData(modelFamily, modelName, serial, capacity, errorCount, powerOnHours, powerCycle, temperature); //wirte data in drive
+
+        pclose(outputfileSmart);
+
+        if (status == 0U)
+        {
+            // Found S.M.A.R.T. data with this command
+            //Logger::logThis()->info("Found S.M.A.R.T. data with this command");
+            break;
+        }
+    }
+
+    drive->setDriveSMARTData(modelFamily, modelName, serial, capacity, errorCount, powerOnHours, powerCycles, temperature); // write data in drive
 }
 
 /**
- * \brief   parse ModelFamiliy
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse ExitStatus
+ * \param string output line of smartctl
+ * \param uint8_t parsed status
+ * \return bool if parsing was possible
  */
-void SMART::parseModelFamily(string sLine)
+bool SMART::parseExitStatus(string sLine, uint8_t &status)
+{
+    string search("\"exit_status\": ");
+    size_t found = sLine.find(search);
+    if (found != string::npos)
+    {
+        sLine.erase(0U, sLine.find(": ") + 1U);
+        status = stol(sLine);
+        return true;
+    }
+    else
+    {
+        return false;
+    }
+}
+
+/**
+ * \brief parse ModelFamily
+ * \param string output line of smartctl
+ * \param string parsed model family
+ * \return bool if parsing was possible
+ */
+bool SMART::parseModelFamily(string sLine, string &modelFamily)
 {
     string search("\"model_family\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ") + 3);
-            sLine.erase(sLine.length()-3, 3);
-            modelFamily = sLine;
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0U, sLine.find(": ") + 3U);
+        sLine.erase(sLine.length() - 3U, 3U);
+        modelFamily = sLine;
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse ModelName
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse ModelName
+ * \param string output line of smartctl
+ * \param string parsed model name
+ * \return bool if parsing was possible
  */
-void SMART::parseModelName(string sLine)
+bool SMART::parseModelName(string sLine, string &modelName)
 {
     string search("\"model_name\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ") + 3);
-            sLine.erase(sLine.length()-3, 3);
-            modelName = sLine;
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0U, sLine.find(": ") + 3U);
+        sLine.erase(sLine.length() - 3U, 3U);
+        modelName = sLine;
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse Serial
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse Serial
+ * \param string output line of smartctl
+ * \param string parsed serial
+ * \return bool if parsing was possible
  */
-void SMART::parseSerial(string sLine)
+bool SMART::parseSerial(string sLine, string &serial)
 {
     string search("\"serial_number\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ") + 3);
-            sLine.erase(sLine.length()-3, 3);
-            serial = sLine;
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0, sLine.find(": ") + 3);
+        sLine.erase(sLine.length() - 3, 3);
+        serial = sLine;
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse Capacity
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse Capacity
+ * \param string output line of smartctl
+ *  \param string parsed capacity
+ * \return bool if parsing was possible
  */
-void SMART::parseCapacity(string sLine)
+bool SMART::parseCapacity(string sLine, uint64_t &capacity)
 {
     string search("\"bytes\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ") + 2);
-            sLine.erase(sLine.length()-1, 1);
-            capacity = stol(sLine);
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0, sLine.find(": ") + 2);
+        sLine.erase(sLine.length() - 1, 1);
+        capacity = stol(sLine);
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse ErrorCount
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse ErrorCount
+ * \param string output line of smartctl
+ * \param uint32_t parsed error count
+ * \return bool if parsing was possible
  */
-void SMART::parseErrorCount(string sLine)
+bool SMART::parseErrorCount(string sLine, uint32_t &errorCount)
 {
     string search("\"error_count_total\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ")+2);
-            sLine.erase(sLine.length()-2, 2);
-            errorCount = stol(sLine);
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0U, sLine.find(": ") + 2U);
+        sLine.erase(sLine.length() - 2U, 2U);
+        errorCount = stol(sLine);
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse PowerOnHours
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse PowerOnHours
+ * \param string output line of smartctl\
+ * \param uint32_t parsed power on hours
+ * \return bool if parsing was possible
  */
-void SMART::parsePowerOnHours(string sLine)
+bool SMART::parsePowerOnHours(string sLine, uint32_t &powerOnHours)
 {
     string search("\"hours\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ") + 2);
-            sLine.erase(sLine.length()-1, 1);
-            powerOnHours = stol(sLine);
-
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0U, sLine.find(": ") + 2U);
+        sLine.erase(sLine.length() - 1U, 1U);
+        powerOnHours = stol(sLine);
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse PowerCycle
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse PowerCycle
+ * \param string output line of smartctl
+ * \param uint32_t parsed power cycles
+ * \return bool if parsing was possible
  */
-void SMART::parsePowerCycle(string sLine)
+bool SMART::parsePowerCycles(string sLine, uint32_t &powerCycles)
 {
     string search("\"power_cycle_count\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
-        {
-            sLine.erase(0, sLine.find(": ") + 2);
-            sLine.erase(sLine.length()-2, 2);
-            powerCycle = stol(sLine);
-
-        }
+    if (found != string::npos)
+    {
+        sLine.erase(0, sLine.find(": ") + 2);
+        sLine.erase(sLine.length() - 2, 2);
+        powerCycles = stol(sLine);
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }
 
 /**
- * \brief   parse temperature
- * \param	string output line of smartctl
- * \return  void
+ * \brief parse temperature
+ * \param string output line of smartctl
+ * \param uint32_t parsed temperature
+ * \return bool if parsing was possible
  */
-void SMART::parseTemperature(string sLine)
+bool SMART::parseTemperature(string sLine, uint32_t &temperature)
 {
     string search("\"current\": ");
     size_t found = sLine.find(search);
-    if (found!=string::npos)
+    if (found != string::npos)
+    {
+        sLine.erase(0U, sLine.find(": ") + 2U);
+        sLine.erase(sLine.length() - 1U, 2U);
+        if (sLine == "{")
         {
-            sLine.erase(0, sLine.find(": ") + 2);
-            sLine.erase(sLine.length()-1, 2);
-            if(sLine == "{")
-                {
-                    temperature = 0U; // this drive doesn't support temperatur
-                }
-            else
-                {
-                    temperature = stol(sLine);
-                }
+            temperature = 0U; // this drive doesn't support temperature
         }
+        else
+        {
+            temperature = stol(sLine);
+        }
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 }