localhorst/reHDD
1
0
Fork 1
Code Issues 6 Pull Requests Releases 10 Wiki Activity

bugfix/ai-static-analysis #82

Merged
localhorst merged 33 commits from bugfix/ai-static-analysis into master 2025-12-10 21:52:17 +01:00
Conversation 2 Commits 33 Files Changed 16 +456 -235
localhorst commented 2025-12-07 19:12:37 +01:00
Owner
Copy Link

The claude.ai LLM performed a static code analysis.

The claude.ai LLM performed a static code analysis.
localhorst added 10 commits 2025-12-07 19:12:38 +01:00
Memory Leak in main.cpp 37cbc9500e
Memory Leak in Drive Scanning ff6a1763e0
Nullptr Return Without Proper Handling 2d63788352
Resource Leak - File Descriptor Not Checked bc4083a98c
Unchecked popen/pclose Return Values bcabad0620
Revert "Unchecked popen/pclose Return Values" eded3f166c 
This reverts commit bcabad0620.
Race Condition with Shared Drive List 46e8dae697
Integer Overflow in sprintf Buffer f303f9f032
Missing Error Check on time() Calls d82c45057b
Unchecked strerror() with Invalid Errno 4afc155230
localhorst reviewed 2025-12-07 19:12:59 +01:00
include/reHDD.h Outdated
@ -32,3 +32,3 @@
// Logic
// #define DRYRUN // don't touch the drives
#define DRYRUN // don't touch the drives
localhorst commented 2025-12-07 19:12:59 +01:00
Author
Owner
Copy Link

Revert before merge

Revert before merge
localhorst marked this conversation as resolved
localhorst added 1 commit 2025-12-07 20:28:03 +01:00
Missing Bounds Check on Array Access c7d37b1d95
localhorst added 1 commit 2025-12-07 20:30:42 +01:00
Missing Validation of Pipe Return Value 2ca0b8b061
localhorst added 1 commit 2025-12-07 20:37:03 +01:00
Iterator Invalidation Bug 460cfeab2c
localhorst added 1 commit 2025-12-07 20:39:08 +01:00
fix terminate if no drive is detected 43ccdbd4d8
localhorst added 1 commit 2025-12-07 20:41:14 +01:00
Uninitialized Memory in cLine ba2f036d88
localhorst commented 2025-12-07 20:41:58 +01:00
Author
Owner
Copy Link

See attached report from claude.ai

See attached report from claude.ai
reHDD_code_analysis.md
20 KiB
localhorst added 1 commit 2025-12-09 21:09:29 +01:00
Using sprintf Instead of snprintf 7c92386082
localhorst added 1 commit 2025-12-09 21:15:52 +01:00
strcpy Without Bounds Checking 8872902990
localhorst added 1 commit 2025-12-09 21:21:49 +01:00
Mutex Not Held During List Size Check f9d63a6a3f
localhorst added 1 commit 2025-12-09 21:23:06 +01:00
Signed/Unsigned Comparison c4cbcb99b5
localhorst added 1 commit 2025-12-09 21:31:36 +01:00
Missing Check for lseek Return Value 228d8ecf6c
localhorst added 1 commit 2025-12-09 21:33:35 +01:00
Deprecated sprintf in Logger 24d0eda150
localhorst added 1 commit 2025-12-09 21:47:24 +01:00
Unchecked ioctl Return Value 2c45158ee8
localhorst added 1 commit 2025-12-09 21:51:53 +01:00
Missing Validation of String Length e5506fd67e
localhorst added 1 commit 2025-12-09 21:53:45 +01:00
Missing Free for getline Allocated Memory c9c4c0fac2
localhorst added 1 commit 2025-12-09 21:59:02 +01:00
Global Using Namespace in Header 15014d8542
localhorst added 1 commit 2025-12-09 21:59:29 +01:00
Unused Semicolon c27471ae03
localhorst added 1 commit 2025-12-09 22:03:04 +01:00
Potential Division by Zero acc05dac8b
localhorst added 3 commits 2025-12-10 21:21:18 +01:00
make members atomic a4f15460d3
fix atomic 4b0ec380b1
Merge pull request 'fix/atomic-drive-members' (#83) from fix/atomic-drive-members into bugfix/ai-static-analysis b953394c0d 
Reviewed-on: #83
localhorst added 1 commit 2025-12-10 21:37:19 +01:00
fix prod build cbf781f0e5
localhorst added 1 commit 2025-12-10 21:44:32 +01:00
fix shred bytes counters 26c42a7e5d
localhorst added 1 commit 2025-12-10 21:49:54 +01:00
add call to logger 9aca86af0c
localhorst merged commit 6060ae13d6 into master 2025-12-10 21:52:17 +01:00
localhorst deleted branch bugfix/ai-static-analysis 2025-12-10 21:52:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
refactor
you can do it better ;-)
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
localhorst
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: localhorst/reHDD#82
No description provided.
Delete Branch "bugfix/ai-static-analysis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?